Skip to content

PATCH: Utils mcp.ts clean up #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2025
Merged

PATCH: Utils mcp.ts clean up #5

merged 2 commits into from
Oct 11, 2025

Conversation

alexortiz201
Copy link
Contributor

There are duplicates of the overload signature in mcp.ts

function sendMcpMessage<Options extends MessageOptions>(
	type: 'link',
	payload: McpMessageTypes['link'],
	options?: Options,
): McpMessageReturnType<Options>

Cleaned this up so the diff tool no longer flags a missing dupe signature. Had to do this for the rest of the downstream exercises' copied files.

kentcdodds
kentcdodds approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@kentcdodds kentcdodds merged commit ff6f94d into epicweb-dev:main Oct 11, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexortiz201 @kentcdodds